Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror CSS should be scoped to EasyMDE #252

Closed
infime opened this issue Oct 5, 2020 · 2 comments
Closed

CodeMirror CSS should be scoped to EasyMDE #252

infime opened this issue Oct 5, 2020 · 2 comments
Labels

Comments

@infime
Copy link

infime commented Oct 5, 2020

Describe the bug

Some CSS selectors (specifically .CodeMirror) are too broad and affect other instances of CodeMirror in an application.

To Reproduce

Import EasyMDE CSS into an app that is already using CodeMirror. Other instances of CodeMirror will have styles intended specifically for EasyMDE applied.

Expected behavior

EasyMDE CSS to only affect it's instance(s) of CodeMirror.

I'd be happy to get this going in a PR.

@infime infime added the Bug label Oct 5, 2020
Ionaru added a commit that referenced this issue Oct 30, 2020
@Ionaru
Copy link
Owner

Ionaru commented Oct 30, 2020

I've added extra scoping to the CSS, please try the @next version to see if that solves your issues.

@infime
Copy link
Author

infime commented Nov 5, 2020

@Ionaru works great, thanks!

@infime infime closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants