Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add two options inputStyle and nativeSpellcheck #143

Merged
merged 5 commits into from
Jan 26, 2020

Conversation

firm1
Copy link

@firm1 firm1 commented Jan 25, 2020

Add two options for enable native (browsers) spellcheck on contenteditable instead of codemirror spellcheck which are limited.

I can link this issue : #52

Copy link

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

README.md Outdated Show resolved Hide resolved
src/js/easymde.js Outdated Show resolved Hide resolved
@Ionaru
Copy link
Owner

Ionaru commented Jan 25, 2020

Can you add this to the changelog as well?

@firm1
Copy link
Author

firm1 commented Jan 26, 2020

@Ionaru and voila.

Cheers.

CHANGELOG.md Outdated Show resolved Hide resolved
@CatalinFrancu
Copy link

Silly question, and I'm sorry if this is the wrong place to ask, but how does one use this? I call the constructor with nativeSpellcheck: true and inputStyle: 'contenteditable', but nothing seems to change. If the field contents are in a language other than English, every word is highlighted. Furthermore, the browser still fetches en_US.{aff,dic} from a CDN.

The demo website, https://easymde.tk/, seems to be down at the moment. Perhaps you could add a contenteditable example under example/?

Thanks!

@A-312
Copy link

A-312 commented Mar 16, 2020

@CatalinFrancu
Copy link

@A-312 Thank you. I tried that, but that disables the spell checker altogether, both the CodeMirror one and the browser one. (The browser spell checker does work in other fields on the same page). Should I replace the textarea with a div? Should I set contenteditable="true" on the HTML element?

@A-312
Copy link

A-312 commented Mar 16, 2020

You a have to use the tagged version next because the release version doesn't have this change yet.

zestedesavoir/zds-site@7eadd7e#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R47

@CatalinFrancu
Copy link

Brilliant! It works perfectly. I don't use npm, so just in case it helps other people, I ran the command npm i easymde@2.9.1-277.0 as described here, then I copied the resulting files from under node_modules/easymde/dist to my source tree.

dimabory added a commit to dimabory/vas3k.club that referenced this pull request Jan 6, 2021
According to Ionaru/easy-markdown-editor#143

Signed-off-by: Dmytro Borysovskyi 🦁
dimabory added a commit to dimabory/vas3k.club that referenced this pull request Jan 6, 2021
According to Ionaru/easy-markdown-editor#143

Signed-off-by: Dmytro Borysovskyi 🦁
vas3k pushed a commit to vas3k/vas3k.club that referenced this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants