Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts for headings #451

Merged
merged 4 commits into from
May 22, 2022
Merged

Add keyboard shortcuts for headings #451

merged 4 commits into from
May 22, 2022

Conversation

vanillajonathan
Copy link
Contributor

These are the same keyboard shortcuts used in TinyMCE.

@Ionaru
Copy link
Owner

Ionaru commented May 19, 2022

I'm not convinced Shift+Alt+1 is the right shortcut for this function. I would prefer it to be more in line with the existing shortcuts.

Maybe Ctrl+Alt+1? That shortcut is also used in Microsoft Word for and probably is more in line with what users would expect.

@vanillajonathan
Copy link
Contributor Author

The reason I used Shift+Alt+1 is because that is what TinyMCE uses.

I can change it to Ctrl+Alt+1 if you would like me to (or you could do it yourself).

@vanillajonathan
Copy link
Contributor Author

What do you think?

@Ionaru
Copy link
Owner

Ionaru commented May 22, 2022

Change it to Ctrl+Alt+1 and add it to the README as well, please.

@Ionaru Ionaru merged commit 3895e0a into Ionaru:master May 22, 2022
@vanillajonathan vanillajonathan deleted the patch-7 branch May 22, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants