chore: adjust the regex for previewing images so that it only attempts to render if the image has a bracket immediately preceding the parentheses #608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the alt of an image has parentheses inside of it and
previewImagesInEditor
istrue
, the editor tries to render the image by making a GET with everything thats after the opening parentheses, e.g.:it tries to do a GET using the base url of the site + that has a parentheses)](my image url) and it results in a 404 error
Example:
http://localhost:8000/that%20has%20a%20parentheses)](my%20image%20url
Solution
in this PR i just fixed the regex that was used to match the src of an image 😄