fix: Display top contributors correctly when larger than chart #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenverCoder1
force-pushed
the
fix-top-contributors
branch
from
e8d6408 to
95176ae
Compare
|
@IonicaBizau Mind taking a look at this? I've rebased the PR and resolved conflicts after the recent changes. Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a major bug in the authors graph where if there are many contributors, only contributors from the bottom of the list get displayed.
This corrects the list to show the top contributors and "others" when the number of contributors is larger than the chart.
Fixes #178
Fixes #126
Example of old chart (wrong)
Does not display "others" and only shows contributors with below 1% of contributions. Top contributors are missing.
Example of fixed chart
Number of contributors displayed is based on the diameter of the chart. "Others" will always be shown when the number of contributors exceeds the maximum.