Skip to content
This repository has been archived by the owner on Dec 31, 2019. It is now read-only.

Hacks to play nice with MC2 #93

Merged
merged 1 commit into from
Feb 14, 2015
Merged

Hacks to play nice with MC2 #93

merged 1 commit into from
Feb 14, 2015

Conversation

TrypChangeling
Copy link
Contributor

Not using RequestResource any more; accessing resources directly - also
overriding the low limit for Spares.

I've been playing with this hack for just about a week alongside MC2 and not had any problems with either mod since. I'm not sure why RequestResource doesn't work but manipulating the resources directly do, but this has cleared up everything for me.

Not using RequestResource any more; accessing resources directly - also
overriding the low limit for Spares.
@602p
Copy link
Collaborator

602p commented Jan 18, 2015

Woohoo!

Thanks so much, I'll take a look in the morning (2 am here) and merge it.

Thank you so much person! :D

@602p
Copy link
Collaborator

602p commented Jan 18, 2015

( Will close #83 )

@TrypChangeling
Copy link
Contributor Author

You got it! Hope it works as well for everyone else as it has for me. Still no idea why the mods don't play nice normally, but I figure if there's a method that works, that's more important. Have a good night!

@602p
Copy link
Collaborator

602p commented Jan 24, 2015

If @Ippo343 doesn't have any objections (waiting on your OK) I'll merge this ASAP.

@Ippo343
Copy link
Owner

Ippo343 commented Jan 24, 2015

Hey Louis, I haven't had the time to review this, and won't have it any time soon.
I'm trusting your judgement, if it's good for you then it's good for me 😊


Da: Louis Goesslingmailto:notifications@github.com
Inviato: ‎23/‎01/‎2015 19:27
A: Ippo343/DangItmailto:DangIt@noreply.github.com
Cc: Michelemailto:m.ippolito@outlook.com
Oggetto: Re: [DangIt] Hacks to play nice with MC2 (#93)

If @Ippo343 doesn't have any objections (waiting on your OK) I'll merge this ASAP.


Reply to this email directly or view it on GitHub:
#93 (comment)

@602p
Copy link
Collaborator

602p commented Feb 14, 2015

This looks good to me :)

Sorry it took so long to merge this :(

602p added a commit that referenced this pull request Feb 14, 2015
@602p 602p merged commit 2a7d2c4 into Ippo343:master Feb 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants