2023 03 12 - Fix failing tests #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvandemo
commented
Mar 13, 2023
| @@ -0,0 +1,8 @@ | |||
| // @ts-ignore | |||
| // @Todo | |||
| // @Ira: when we run `ng test`, the tests in helpers.spect.ts fail. | |||
There was a problem hiding this comment.
@IraLysenko Some unit tests were added in helpers.spec.ts.
When you run run ng test, you will notice that some of them fail because the makeAuthorsUnique function is not implemented correctly.
Challenge: can you make the tests succeed? ⚡
Thanks and best of luck! 🍀
There was a problem hiding this comment.
@jvandemo
Challenge accepted 🙏 🙇
Thank you very much for your time!🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.