Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address judging tests #3855

Closed
shaun-technovation opened this issue Feb 16, 2023 · 1 comment
Closed

Address judging tests #3855

shaun-technovation opened this issue Feb 16, 2023 · 1 comment
Assignees
Labels

Comments

@shaun-technovation
Copy link
Contributor

The following tests should be updated/fixed, or removed:

scoring submissions when a junior team receives a perfect score
  # Temporarily disabled with xfeature
  # ./spec/features/judge/scoring_submissions_spec.rb:12

scoring submissions when a senior team receives a perfect score
  # Temporarily disabled with xfeature
  # ./spec/features/judge/scoring_submissions_spec.rb:26

starting scores as an RPE judge able to resume scoring an assigned submission
  # Temporarily skipped with xcontext
  # ./spec/features/judge/starting_scores_spec.rb:52

starting scores as an RPE judge see start buttons for all assigned submissions
  # Temporarily skipped with xcontext
  # ./spec/features/judge/starting_scores_spec.rb:42

starting scores as an RPE judge no button to score virtual submissions
  # Temporarily skipped with xcontext
  # ./spec/features/judge/starting_scores_spec.rb:23

starting scores as an RPE judge able to start scoring an assigned submission
  # Temporarily skipped with xcontext
  # ./spec/features/judge/starting_scores_spec.rb:32

starting scores as an RPE judge able to review completed score for an assigned submission
  # Temporarily skipped with xcontext
  # ./spec/features/judge/starting_scores_spec.rb:64

starting scores as a virtual judge starting a new score
  # Temporarily disabled with xfeature
  # ./spec/features/judge/starting_scores_spec.rb:86

starting scores as a virtual judge continuing with an unfinished score
  # Temporarily disabled with xfeature
  # ./spec/features/judge/starting_scores_spec.rb:106

starting scores as a virtual judge unable to start new score with a score in progress
  # Temporarily disabled with xfeature
  # ./spec/features/judge/starting_scores_spec.rb:96

starting scores as a virtual judge reviewing a completed score
  # Temporarily disabled with xfeature
  # ./spec/features/judge/starting_scores_spec.rb:117
@viviancan
Copy link
Contributor

The following test was added

scoring submissions when a beginner team receives a perfect score

The following tests were updated

scoring submissions when a junior team receives a perfect score
  # Temporarily disabled with xfeature
  # ./spec/features/judge/scoring_submissions_spec.rb:12

scoring submissions when a senior team receives a perfect score
  # Temporarily disabled with xfeature
  # ./spec/features/judge/scoring_submissions_spec.rb:26

starting scores as a virtual judge starting a new score
  # Temporarily disabled with xfeature
  # ./spec/features/judge/starting_scores_spec.rb:86

starting scores as a virtual judge continuing with an unfinished score
  # Temporarily disabled with xfeature
  # ./spec/features/judge/starting_scores_spec.rb:106

starting scores as a virtual judge unable to start new score with a score in progress
  # Temporarily disabled with xfeature
  # ./spec/features/judge/starting_scores_spec.rb:96

starting scores as a virtual judge reviewing a completed score
  # Temporarily disabled with xfeature
  # ./spec/features/judge/starting_scores_spec.rb:117

The following tests were removed since they are part of the starting_rpe_scores_spec

starting scores as an RPE judge able to resume scoring an assigned submission
  # Temporarily skipped with xcontext
  # ./spec/features/judge/starting_scores_spec.rb:52

starting scores as an RPE judge see start buttons for all assigned submissions
  # Temporarily skipped with xcontext
  # ./spec/features/judge/starting_scores_spec.rb:42

starting scores as an RPE judge no button to score virtual submissions
  # Temporarily skipped with xcontext
  # ./spec/features/judge/starting_scores_spec.rb:23

starting scores as an RPE judge able to start scoring an assigned submission
  # Temporarily skipped with xcontext
  # ./spec/features/judge/starting_scores_spec.rb:32

starting scores as an RPE judge able to review completed score for an assigned submission
  # Temporarily skipped with xcontext
  # ./spec/features/judge/starting_scores_spec.rb:64

@dboyer dboyer closed this as completed Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants