Allow chapter ambassadors to view any participant in their region #5377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaun-technovation
force-pushed
the
5300-allow-chas-to-view-participants-in-region
branch
from
77ac899 to
6ec4cee
Compare
shaun-technovation
changed the title
| } | ||
| ) | ||
| .find(params[:id]) | ||
| if params[:search_in_region].present? |
There was a problem hiding this comment.
This is the new URL parameter I added search_in_region, open to changing that. If that's present it will use the old in_region functionality.
There was a problem hiding this comment.
I think the naming is clear 👍
|
|
||
| @teams = Team | ||
| .current | ||
| .in_region(current_ambassador) |
There was a problem hiding this comment.
This will display teams (for team assignment) based on their region.
| current_ambassador.chapterable_type, | ||
| current_ambassador.current_chapterable.id | ||
| ) | ||
| .distinct |
There was a problem hiding this comment.
And this will display teams for their chapter or club (addressing the feedback in #5363).
| @@ -508,6 +508,16 @@ def chapter_ambassador | |||
| .where("background_checks.status = ?", BackgroundCheck.statuses[:suspended]) | |||
| } | |||
|
|
|||
| scope :by_chapterable, ->(chapterable_type, chapterable_id) do | |||
There was a problem hiding this comment.
Created a new by_chapterable scope here to match our other ones.
|
|
||
| def secondary_regions | ||
| [] | ||
| end |
There was a problem hiding this comment.
This is needed for the in_region search.
viviancan
approved these changes
Feb 12, 2025
shaun-technovation
force-pushed
the
5300-allow-chas-to-view-participants-in-region
branch
from
6ec4cee to
32f1d63
Compare
This will let club ambassadors assign a student or a mentor to a team. Chapter ambassadors already had this functionality, to make it work for club ambassadors I extracted the existing functionality and made it so that both chapter ambassadors and club ambassadors can share the same functionality. Refs: #5331
This will bring back the functionality that will let chapter ambassadors view any participant in their region. It works by adding a `search_in_region` URL parameter, if this URL parameter is present, it will use the old `.in_region` functionality to find participants. Refs: #5300
Addressing formatting issues. Refs: #5300
When an ambassador assigns a participant to a team, we want to restrict which teams are displayed. - If an ambassador is viewing a participant in their region we'll display all of the teams in their region - Otherwise we'll only display teams that belong to their chapter or club Refs: #5378
This will address a Bullet gem warning about including :mentor_profile. Refs: #5300
Creating this scope to make it consistent with our other main Rails models, like `Team` and `TeamSubmission`. Refs: #5300
shaun-technovation
force-pushed
the
5300-allow-chas-to-view-participants-in-region
branch
from
32f1d63 to
5a1add9
Compare
shaun-technovation
deleted the
5300-allow-chas-to-view-participants-in-region
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will bring back the functionality that will let chapter ambassadors view any participant in their region. It works by adding a
search_in_regionURL parameter, if this URL parameter is present, it will use the old.in_regionfunctionality to find participants.Also, when an ambassador assigns a participant to a team, this will restrict which teams are displayed (to select from):
If an ambassador is viewing a participant in their region we'll display all of the teams in their region
Otherwise we'll only display teams that belong to their chapter or club