Skip to content

Comments

Sub text modifiers#19

Merged
PeachesMLG merged 7 commits intoIridium-Development:masterfrom
boiscljo:master
Dec 15, 2021
Merged

Sub text modifiers#19
PeachesMLG merged 7 commits intoIridium-Development:masterfrom
boiscljo:master

Conversation

@boiscljo
Copy link

Allow modifier to be applied to only parts of the text

Support for SPECIAL_COLOR inside the string but won't apply on the whole string
unknown

Copy link
Member

@PeachesMLG PeachesMLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the new Lines

Copy link
Member

@PeachesMLG PeachesMLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be good to get some unit tests around the new changes

@boiscljo
Copy link
Author

Sorry that I accidently did a "Format document" in my IDE, that's why all the new lines.

@PeachesMLG
Copy link
Member

Also add a unit test for gradients aswell

@boiscljo
Copy link
Author

Should I fix the 2 Codacy Static Code Analysis?
I added the UnitTests

@PeachesMLG
Copy link
Member

Should I fix the 2 Codacy Static Code Analysis? I added the UnitTests

Yeah fix those aswell

@PeachesMLG PeachesMLG merged commit e9b1c3f into Iridium-Development:master Dec 15, 2021
PeachesMLG added a commit that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants