Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port IronLanguages/ironpython3#1643 to ironpython2 for #838. #839

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Port IronLanguages/ironpython3#1643 to ironpython2 for #838. #839

merged 1 commit into from
Feb 5, 2024

Conversation

mickp
Copy link
Contributor

@mickp mickp commented Feb 3, 2024

No description provided.

@mickp
Copy link
Contributor Author

mickp commented Feb 3, 2024

@dotnet-policy-service agree

@mickp
Copy link
Contributor Author

mickp commented Feb 3, 2024

Unfortunately, I'm unable to run the tests - I see errors on build relating to the use of file as a type name:
loadtypesample.cs(110, 18): [CS9056] Types and aliases cannot be named 'file'.
loadtypesample.cs(110, 18): [CS9056] Types and aliases cannot be named 'file'.

slozier
slozier approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickp Thanks for the PR. Seems fine so I'll merge it. Will have to see if I can get ipy2 building again...

@slozier slozier merged commit d834e17 into IronLanguages:master Feb 5, 2024
1 of 4 checks passed
@mickp mickp deleted the map_838 branch February 5, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slozier slozier slozier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickp @slozier