🐛 fix over-agressive memoization

IsaacInsoll · Nov 13, 2024 · 31e6c90 · 31e6c90
1 parent c89db89
commit 31e6c90
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/frontend/src/components/FileListView/FolderContentsView.tsx b/frontend/src/components/FileListView/FolderContentsView.tsx
@@ -49,17 +49,16 @@ export const FolderContentsView = ({ folder }) => {
   };
 
   useEffect(() => resetFilters(null), [resetFilters, folderId]);
-  const props = useMemo(() => {
-    console.log('FCV props recalculate');
-    const filteredFiles = filtering ? filterFiles(files, filters) : files;
-    return {
-      folderId,
-      folders: folder.subFolders,
-      files: filteredFiles,
-      selectedFileId: fileId,
-      setSelectedFileId,
-    };
-  }, [folderId, filters]);
+
+  // don't memo files because it breaks graphicache (IE: file changing rating won't reflect)
+  const filteredFiles = filtering ? filterFiles(files, filters) : files;
+  const props = {
+    folderId,
+    folders: folder.subFolders,
+    files: filteredFiles,
+    selectedFileId: fileId,
+    setSelectedFileId,
+  };
 
   console.log('FCV render');
   return (