Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break apart github repos for islandora modules #475

Closed
dannylamb opened this issue Jan 3, 2017 · 14 comments
Closed

Break apart github repos for islandora modules #475

dannylamb opened this issue Jan 3, 2017 · 14 comments
Assignees

Comments

@dannylamb
Copy link
Contributor

dannylamb commented Jan 3, 2017

Composer works with a 'package per github repo' fashion, so let's break them apart. Use the git subtree command to preserve history on the islandora_collection module and pull it into its own repo. Also, move the contents of the remaining islandora folder to the top level of the repository.

@dannylamb dannylamb self-assigned this Jan 3, 2017
@ruebot
Copy link
Member

ruebot commented Jan 3, 2017

Wouldn't this violate our one repo on Drupal.org rule that we've been going with?

@dannylamb
Copy link
Contributor Author

Sadly, yes it would. I'm not happy about it.

@ruebot
Copy link
Member

ruebot commented Jan 3, 2017

Agenda item for Wednesday's call? I'd prefer to talk about this more so I can understand it better before we move forward.

@dannylamb
Copy link
Contributor Author

np

@ruebot
Copy link
Member

ruebot commented Jan 3, 2017

@dannylamb
Copy link
Contributor Author

dannylamb commented Jan 3, 2017

#27

@dannylamb
Copy link
Contributor Author

@dannylamb
Copy link
Contributor Author

@DiegoPino
Copy link
Contributor

DiegoPino commented Jan 3, 2017

@dannylamb @ruebot. To add to the discussion tomorrow some alternatives we discussed via other media.

  • https://packagist.org/packages/mile23/drupal-merge-plugin or the better supported wikimedia/composer-merge-plugin
    This plugin searches for composer.json files in user contributed modules and tries to satisfy it's dependencies. Does not require that we transform or move all modules or whole drupal to composer.
  • Make this just an install task, without any code change or repo reorganization until we have a better solution (yes, not intended to be an automatic, good for all solution)
    on drupal root directory run
 composer update
 composer require stomp-php/stomp-php

Some last thoughts: Composer is the way to go of course. But the composer way of drupal is still a bit "betaish", not straight forward, still depends many times on drush(to enable modules) and requires in any case a lot of modifications to the composer.json file itself or adding extra install tasks.

@ruebot
Copy link
Member

ruebot commented Jan 3, 2017

https://packagist.org/packages/mile23/drupal-merge-plugin

"Note: This project is in development. It currently does not have even any releases."

@dannylamb
Copy link
Contributor Author

@DiegoPino Yes, there are other ways of installing the requirement for stomp-php that do not involve breaking up the repositories. I'm proposing this restructuring to get something potentially very costly and time consuming out of the way early before we start collecting more modules.

@ruebot The real concern for me is what this shift means for our yet to be defined release process.

@whikloj
Copy link
Member

whikloj commented Jan 20, 2017

@ruebot @dannylamb I think this is done, no?

@ruebot
Copy link
Member

ruebot commented Jan 20, 2017

@whikloj I'd say so

@whikloj
Copy link
Member

whikloj commented Jan 20, 2017

Resolved with various PRs referenced in this ticket and the new https://github.com/Islandora-CLAW/claw_vagrant repo

@whikloj whikloj closed this as completed Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants