Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install D8 and modules using composer #476

Merged
merged 7 commits into from
Jan 17, 2017
Merged

Conversation

dannylamb
Copy link
Contributor

@dannylamb dannylamb commented Jan 3, 2017

Install PR for #474 and #475

Testing instructions

  • Pull down the code from this PR
git checkout -b dannylamb-composer master
git pull https://github.com/dannylamb/CLAW.git composer
  • visit https://github.com/settings/tokens and get an oauth token (check the 'repos' checkbox when making it)
  • put your token in install/configs/variables as the GITHUB_TOKEN variable (it's set to 'changeme' by default)
  • vagrant up

Functionality should remain the same. I tested by creating, editing, and then deleting a fedora resource, and made sure the rules actions were firing.

@dannylamb dannylamb force-pushed the composer branch 2 times, most recently from 36b31b3 to 6869c0c Compare January 3, 2017 18:00
@dannylamb
Copy link
Contributor Author

dannylamb commented Jan 13, 2017

Initial testing has found that we hit a rate limit for github requests through composer. We can fix that for devs by allowing them to provide their authentication creds in configuration. For users without github accounts, we need to provide 'stable' releases through packagist.

@dannylamb
Copy link
Contributor Author

This works right now using an oauth token from github. I'll update the README in this pull later.

Long term, the solution is just to get on packagist and have small, frequent releases. I'm already bringing this up at the next committers meeting https://github.com/Islandora-CLAW/CLAW/wiki/January-18%2C-2017

@whikloj
Copy link
Member

whikloj commented Jan 16, 2017

Ok, new vagrant with an OAuth token and this branch ended up with a loop trying to download restui

==> default: restui was not found.                                                  [warning]
==> default: The following projects provide some or all of the extensions not            [ok]
==> default: found:
==> default: restui
==> default: Would you like to download them? (y/n): 
==> default: y
==> default: This codebase is assembled with Composer instead of Drush. Use           [error]
==> default: `composer update` and `composer require` instead of `drush
==> default: pm-updatecode` and `drush pm-download`. You may override this error
==> default: by using the --pm-force option.
==> default: restui was not found.                                                  [warning]
==> default: The following projects provide some or all of the extensions not            [ok]
==> default: found:
==> default: restui
==> default: Would you like to download them? (y/n): 
==> default: y
==> default: This codebase is assembled with Composer instead of Drush. Use           [error]
==> default: `composer update` and `composer require` instead of `drush
==> default: pm-updatecode` and `drush pm-download`. You may override this error
==> default: by using the --pm-force option.

So either we add the --pm-force or change the drush dl to composer require.

Preferences?

@whikloj
Copy link
Member

whikloj commented Jan 16, 2017

Just as a note I modified the restui one to say

composer require "drupal/restui:~8.x-1.0"

and then got stuck on a loop at the next one. So this is not limited to restui.

@DiegoPino
Copy link
Contributor

@whikloj I say, let's talk about this tomorrow on CLAW tech call?I feel our approach is not working or we are doing something wrong?

@dannylamb
Copy link
Contributor Author

dannylamb commented Jan 16, 2017

@whikloj That loop happens if you try and drush dl something. You have to switch to composer require or actually just put it in the require section of the composer.json.

@DiegoPino
Copy link
Contributor

@whikloj we should swich to installing drush globally
composer global require drush/drush

@whikloj
Copy link
Member

whikloj commented Jan 16, 2017

This was all my mistake, I cloned the wrong drupal-project repo. Stay tuned.

@whikloj
Copy link
Member

whikloj commented Jan 16, 2017

👍 ok now it works, if you use @dannylamb's drupal-project branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants