Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppa documentation. #1217

Merged
merged 4 commits into from
Aug 9, 2019

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Jul 12, 2019

GitHub Issue: #848

What does this Pull Request do?

Add documentation on how to add a package to the Lyrasis PPA.

What's new?

Documentation!

How should this be tested?

  • hugo
  • Read it and see if the prose and typos are good.

Additional Notes:

Part of a few PRs that will address #848.

Interested parties

@Islandora-CLAW/committers

@jonathangreen
Copy link
Contributor

jonathangreen commented Jul 12, 2019

I wonder if its worth linking in this documentation to the Ubuntu tickets explaining why ImageMagick don't support JP2 out of the box, so we can monitor them next time when we're updating to the next Ubuntu version?

https://bugs.launchpad.net/ubuntu/+source/imagemagick/+bug/1447968

@ruebot
Copy link
Member Author

ruebot commented Jul 19, 2019

@jonathangreen updated!

@ruebot
Copy link
Member Author

ruebot commented Jul 19, 2019

Should we include this one too @jonathangreen?

@jonathangreen
Copy link
Contributor

👍🏻 Sounds good to me.

@jonathangreen
Copy link
Contributor

One other comment on this one, would it make sense to list the files that you modified for the package, just to make it easier to remember which ones to modify to add the dependancies next time? Once that's added I'm good with this 👍🏻

@ruebot
Copy link
Member Author

ruebot commented Aug 9, 2019

Yeah, that's a good idea. Let me pull together a diff, or see if I have one hanging around, and I'll add it.

@ruebot
Copy link
Member Author

ruebot commented Aug 9, 2019

@jonathangreen updated!

Copy link
Contributor

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathangreen jonathangreen merged commit 94d54ee into Islandora:master Aug 9, 2019
@ruebot ruebot deleted the ppa-documentation branch August 9, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants