-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Claw-playbook: Update to fully support Ubuntu 18.04 'Bionic Beaver' #848
Comments
Thanks for this. I'm definitely 👍 to supporting the latest ubuntu LTS. |
Linking to #950, I definitely want to ship with the latest LTS. |
I can take this one if y'all want. |
I guess a larger question here as I'm working on it, is do y'all just want to move to 18.04 or support 16.04 and 18.04 at the same time? If it is the latter things are gonna get really complicated. It's definitely doable, but will be awful to support and maintain. Maybe just move to 18.04? |
We need to update the imagemagick ppa to 18.04. Bit of irc discussion here. Happy to do this work as well. |
Moving up to 18.04 was something I wanted to do pre-release but there just wasn't enough time. I'd prefer to just move to 18.04, but Im brutal and want to maintain as little as possible. |
I'd say move, this is a demo/development box. If you are installing this on your server you can setup whatever OS you want. |
Running into the following issue on ubuntu 18:
|
@Natkeeran I think 'libpng16-dev' is now just 'libpng-dev'. |
That's what I updated in my branch last week. Won't get back to working on it until Friday (July 4th) at the earliest. The next place the build breaks down is what I mentioned above with the imagemagick ppa. I had planned on getting back to that on Friday, but if y'all need it sooner, feel free to assign it to somebody else. |
Maybe this will help, this works on both Ubuntu 16/18LTS with Ansible 2.8.1 this was my solution for Islandora8 once I found Lyrasis's PPA not working. fine_name: imagemagick_from_src.yml `- name: Compile ImageMagic from source tasks:
|
@jonathangreen Any plans to provide a repo for bionic similar to http://ppa.launchpad.net/lyrasis/imagemagick-jp2/ubuntu/dists/ ? |
IRC discussion from here:
@Natkeeran I don't have time at the moment to work on it, but if anyone wants to push a package to that PPA they are more than welcome to and I can provide access, or maybe we should create a Islandora PPA to install from. @ruebot I believe is going to work making the package when he has the bandwidth to work on it. We could also install from source as mentioned earlier in this thread. I personally am not the hugest fan of doing that within playbooks, since you have to manager versions and make sure things are idempotent and it makes the playbook run longer as you have to do the compile. It is however possible, and might be the easiest thing to do here. |
- Update Vagrantfile to use 18.04 for Ubuntu builds - Tweak package names, and required packages for 18.04 - Updates to get rid of some deprecation warnings - Addresses Islandora/documentation#848 - Requires islandora-deprecated/ansible-role-grok#6
Should be good to go for testing:
PPA uploaded to Launchpad: https://launchpad.net/~lyrasis/+archive/ubuntu/imagemagick-jp2/+packages |
Technically everything is there, but it still crashes 😢
I'll dig back in on the 19th. |
Is jp2 listed as a supported codec if you just run `convert`?
…On Fri, Jul 12, 2019, 20:33 Nick Ruest ***@***.***> wrote:
convert still crashes on jp2 conversion with the most recent version of
imagemagick I have up on the PPA.
Technically everything is there, but it still crashes 😢
***@***.***:/tmp$ convert yul_99144_OBJ_Datastream.tiff test.jp2
Aborted (core dumped)
***@***.***:/tmp$ convert -list format | grep -i JP2
J2C* JP2 rw- JPEG-2000 Code Stream Syntax (2.3.0)
J2K* JP2 rw- JPEG-2000 Code Stream Syntax (2.3.0)
JP2* JP2 rw- JPEG-2000 File Format Syntax (2.3.0)
JPC* JP2 rw- JPEG-2000 Code Stream Syntax (2.3.0)
JPM* JP2 rw- JPEG-2000 Code Stream Syntax (2.3.0)
JPT* JP2 rw- JPEG-2000 File Format Syntax (2.3.0)
I'll dig back in on the 19th.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#848>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE6PSH5XIJP53FNAKI2RIQLP7EIEBANCNFSM4FGJHT6Q>
.
|
Yep.
|
💩 That's all I've got 🤷♂️ |
I know centos uses an old version of openjpeg that is problematic. Perhaps 2.3.1 fixes it? |
This one has openjpeg 2.3.0. I'll dig into it, and see how difficult it'll be to get 2.3.1 there. Worse case, it's like with 16.04, and the PPA has ImageMagick and openjpeg debs. |
I just tested the PPA version of imagemagick on a clean fresh vagrant box and it all looked okay to me. I wonder if maybe its the JP2 you are using for testing @ruebot? What I tried:
So at least for me it seems like its working okay! |
Weird. Failed for me doing the same thing.
I did a
Still the same. 😢 @seth-shaw-unlv @dannylamb or anybody else mind doing doing @jonathangreen's sanity test when you have some time? |
@ruebot I for sure screwed up copy/pasting that
Note the big O in |
🤦♂️ I should have caught that too! Good news! IT WORKS.
🤘 🤘 ...and I just realized were the So, the 18.04 ppa I did is totally fine, and I have a gremlin somewhere, or we have a gremlin somewhere in the claw vagrant build. |
* Update to 18.04 - Update Vagrantfile to use 18.04 for Ubuntu builds - Tweak package names, and required packages for 18.04 - Updates to get rid of some deprecation warnings - Addresses Islandora/documentation#848 - Requires islandora-deprecated/ansible-role-grok#6 * Update README and remove some cruft per @Natkeeran's review. * use ansible-role-grok 2.0.0 * review * cut more
* Update to 18.04 - Update Vagrantfile to use 18.04 for Ubuntu builds - Tweak package names, and required packages for 18.04 - Updates to get rid of some deprecation warnings - Addresses Islandora/documentation#848 - Requires islandora-deprecated/ansible-role-grok#6 * Update README and remove some cruft per @Natkeeran's review. * use ansible-role-grok 2.0.0 * review * cut more
Related to #842
Once a pull-request has been committed for #842 has been committed, there needs to be some deb name updates to reflect the fact that Ubuntu 18.04 has renamed some packages. Examples include
php7.0-common
tophp-common
.It is also anticipated that some ansible
when
clauses will be required to detect whenubuntu/bionic64
is being used.The text was updated successfully, but these errors were encountered: