Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite as symfony-flex #73

Closed
wants to merge 3 commits into from
Closed

Rewrite as symfony-flex #73

wants to merge 3 commits into from

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Jul 19, 2019

GitHub Issue: Islandora/documentation#1224

Depends on the branch - Islandora/Crayfish-Commons#26

What does this Pull Request do?

This PR recreates the Houdini microservice using Symfony/flex.

I will work on a PR for claw-playbook and ansible-role-crayfish

What's new?

Changes to the symfony/flex framework.
To configure the firewall you do that in config/packages/security.yaml
To configure logging you do that in config/packages/monolog.yaml
To configure crayfish commons you do that in config/packages/crayfish_commons.yaml

  • Does this change require documentation to be updated? yes
  • Does this change add any new dependencies? yes, changes
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

Currently I was testing by:

  • Standing up a normal claw-playbook.
  • Add a binary image to the Islandora 8 and get the URL for Fedora.
  • Check out this branch.
  • cd ./Houdini
  • composer install
  • php ./bin/console server:start
    Get the host and port, then ensure your crayfish_commons.yaml has the correct settings, including the location to the example syn-settings.xml
  • curl -i -H"Accept: image/png" -H"Apix-Ldp-Resource: <fedora url>" -H"X-Islandora-Args: -resize 100x>" http://localhost:<symfony port>/convert -> 401 Unauthorized
  • curl -i -H"Accept: image/png" -H"Apix-Ldp-Resource: <fedora url>" -H"X-Islandora-Args: -resize 100x>" -H"Authorization: Bearer bob" http://localhost:<symfony port>/convert -> 403 Forbidden
  • curl -o test.png -H"Accept: image/png" -H"Apix-Ldp-Resource: <fedora url>" -H"X-Islandora-Args: -resize 100x>" -H"Authorization: Bearer islandora" http://localhost:<symfony port>/convert -> view the resized image in test.png

Interested parties

@Islandora-CLAW/committers

@whikloj
Copy link
Member Author

whikloj commented Jul 19, 2019

Curse you Gemini!! CURSE YOU!!!
foiled again

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #73 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev      #73   +/-   ##
=========================================
  Coverage     94.59%   94.59%           
  Complexity      159      159           
=========================================
  Files             9        9           
  Lines           647      647           
=========================================
  Hits            612      612           
  Misses           35       35
Impacted Files Coverage Δ Complexity Δ
Houdini/src/Controller/HoudiniController.php 100% <100%> (ø) 12 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcf192...d65dd20. Read the comment docs.

@whikloj
Copy link
Member Author

whikloj commented Aug 13, 2019

Ok I'm closing this and the associated Crayfish-Commons PR. I did some work on the ansible role and some seemingly correct decisions here, fail when run through ansible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant