Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1224
What does this Pull Request do?
Rewrites the existing Crayfish-Commons as a Symfony bundle.
What's new?
YamlServiceProvider is removed, symfony handles configuration differently.
IslandoraServiceProvider is removed, this work is done in CrayfishCommonsExtension
ApixMiddleware becomes an EventSubscriber
Added a UserProvider for the JWTs
Does this change require documentation to be updated? yes
Does this change/add any new dependencies? dependencies changed, as did the composer.lock
Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
Could this change impact execution of existing code? probably
How should this be tested?
A subsequent PR is coming for Houdini.
Then I'll create a PR to pull this into a playbook and we can test it there.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers