Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite as Symfony bundle #26

Closed
wants to merge 4 commits into from
Closed

Rewrite as Symfony bundle #26

wants to merge 4 commits into from

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Jul 18, 2019

GitHub Issue: Islandora/documentation#1224

What does this Pull Request do?

Rewrites the existing Crayfish-Commons as a Symfony bundle.

What's new?

  • YamlServiceProvider is removed, symfony handles configuration differently.

  • IslandoraServiceProvider is removed, this work is done in CrayfishCommonsExtension

  • ApixMiddleware becomes an EventSubscriber

  • Added a UserProvider for the JWTs

  • Does this change require documentation to be updated? yes

  • Does this change/add any new dependencies? dependencies changed, as did the composer.lock

  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no

  • Could this change impact execution of existing code? probably

How should this be tested?

A subsequent PR is coming for Houdini.
Then I'll create a PR to pull this into a playbook and we can test it there.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@e65b2bb). Click here to learn what that means.
The diff coverage is 49.41%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev      #26   +/-   ##
======================================
  Coverage       ?   82.61%           
  Complexity     ?      127           
======================================
  Files          ?       10           
  Lines          ?      397           
  Branches       ?        0           
======================================
  Hits           ?      328           
  Misses         ?       69           
  Partials       ?        0
Impacted Files Coverage Δ Complexity Δ
Syn/JwtUser.php 53.84% <ø> (ø) 6 <0> (?)
Client/GeminiClient.php 98.55% <ø> (ø) 15 <0> (?)
Syn/SettingsParser.php 92.03% <ø> (ø) 47 <0> (?)
Syn/JwtFactory.php 0% <ø> (ø) 1 <0> (?)
DependencyInjection/Configuration.php 0% <0%> (ø) 1 <1> (?)
Syn/JwtUserProvider.php 0% <0%> (ø) 3 <3> (?)
DependencyInjection/CrayfishCommonsExtension.php 0% <0%> (ø) 5 <5> (?)
CmdExecuteService.php 84.09% <66.66%> (ø) 14 <1> (?)
ApixMiddleware.php 88.57% <70%> (ø) 8 <5> (?)
Syn/JwtAuthenticator.php 95.29% <91.66%> (ø) 27 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65b2bb...2337ce6. Read the comment docs.

@whikloj
Copy link
Member Author

whikloj commented Aug 13, 2019

@whikloj whikloj closed this Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant