make sure to add trailing slashes, they are important #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dannylamb
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
All good @Natkeeran. Provisions fine and passes basic sanity tests.
whikloj
pushed a commit
to whikloj/claw-playbook
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you to Danny for troublshotting this issue.
What does this Pull Request do?
This PR resolves an issue introduced with this PR: https://github.com/Islandora-Devops/claw-playbook/commits/dev.
It adds the trailing slash required by the flysystem config.
How should this be tested?
Additional Notes:
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers
@dannylamb May want to have a quick look at this one as the current playbook is broken. Thank you.