-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paged content config #143
Paged content config #143
Conversation
What's the story with JP2 support? |
It would work the same way as a tiff. If you already have JP2s you're already fine (try one though, please!). If you need to generate them, I think we're hung up on reliably generating them. But its been a while since we've investigated that. |
@dannylamb great, we are generating the JP2s already so I can test that tomorrow |
@dannylamb @DonRichards I tested this with ingested JP2s and it worked as advertised...so if you have JP2s pre-created then you can use them... |
any chance the thumbnail panel at the bottom could be made smaller.... |
@rangel35 Yep. In Configuration > Media > Openseadragon settings, there's a slew of options to play with. |
is there a way to add page level metadata to the display...currently only the top book level metadata shows up for every page but if the individual children also contain metadata that is lost (not displayed) |
Off the top of my head I don't know. If you can put it in the manifest, and i can pass it to the viewer, then in theory it's possible. |
FYI I've noticed that when viewing individual pages with openseadragon, there's some issues. Sequence mode when there's only one item really messes with things. I'll see if I can make the viewer autodetect if they need to go into sequence mode. |
@rangel35, I mentioned that to @dannylamb on a thread in Slack. OpenSeadragon does support overlays that can add metadata (see the "Overlaying Complex HTML" example in the linked page); although the provided example didn't persist across the sequence paging. I'm sure we could do it, but not in time for IslandoraCon or even 1.1 unless someone got cracking on it now. Brainstorming here: we would have to add a relationship between the media at it's node in the IIIF Manifest view to get the fields we want to display and then update the IIIF Manifest formatter to include it. Although, does the IIIF manifest have a place for descriptive metadata? 🤷♂️ I'm actually interested in how Mirador works with it. |
thanks @seth-shaw-unlv I'll take a look at the link...the current install works great for generic books but we have legal documents that are paged and have page level metadata @dannylamb I also noticed that if you start in page 2 it won't go to page 3 and beyond even if they do exist....this would prevent people from starting at say page 100 and continuing to finish if there is a 500 page document. |
@rangel35 I have some basic views that help with that scenario (although they need refinement). I still need to get them to jump to a certain point in the listing... but it is better than nothing. |
thanks @seth-shaw-unlv I was thinking along the lines of trying to create a block for the metadata |
I've pushed up changes for autodetecting sequence mode, with collection mode overriding it if user chooses to select it. I'm testing the build now. |
This passes my smoke test and is ready to be tested by the larger group again. |
@seth-shaw-unlv mirador has some capabilities built in to display metadata. i'll see if i can throw together a demo of what i mean real quick. |
I think the main issue will be getting the page level metadata into the manifest so that mirador can access it |
Well instead of trying to do that in islandora real fast - https://projectmirador.org/demo/ if you click the i icon in the upper right corner you get a little metadata hover. I agree with @rangel35 it'd just be a matter of getting that into the manifest, which would probably involve some additional work in https://github.com/Islandora-CLAW/islandora/blob/8.x-1.x/modules/islandora_iiif/src/Plugin/views/style/IIIFManifest.php |
|
@elizoller I was getting that earlier. Do you have this commit? ff50c3a I have to put the openseadragon version in islandora_default's composer.json and in that inventory variable from that commit. |
No because i have claw-playbook:paged-content-config instead of dannylamb:paged-content-config :( |
Then I just do:
|
To keep this up-to-date. On the paged_content object I am seeing
@dannylamb is looking into setting the |
I followed @whikloj's notes above but at
I get
|
Specifying the specific commit |
Running into the following issue when trying to vagrant up this PR:
|
Just successfully spun up a box with these latest changes. This pulls in the newest theme, which fixes an issue when placing blocks with contexts that @whikloj found. Folks can give it a try. |
I got similar error messages to seth but as i went further into the test i got an additional one: |
The theme update fixed a somewhat edge-y case, so we can always revert if it's problematic and leave it as a 'known issue'. But if you're developing with caching disabled, it's fixes something pretty annoying. @elizoller That one isn't related to the theme. It shows up a lot anyway. I think I just need to lower the level of that message. @seth-shaw-unlv I think the manifest is ok and i'm not parsing it correctly. I'll look into it. I've made a paged content node and then been redirected to it after submitting the form so i'm surprised i haven't seen that one yet. |
Oh noes... when testing the fix for @seth-shaw-unlv's empty paged content issue, I ran into a new one. Make two books. The block gets cached. Visit one and then the other. The second block is the same as for the first object. Gotta get that caching sorted out 😭 |
Alright, I pushed up some changes to openseadragon to do better caching. Now you don't have to clear your caches all the time! It also works if you have more than one 'paged content' object now. Good thing we caught that before the conference ^_^ I'm vagrant up'ing now to confirm. But this should be good to test one more time. |
Let me know if you want me to revert the theme changes. Easy enough to do. |
Of course I started my build 20 minutes ago, or 15 minutes before the last change. ✊ LAMB!!!! |
In theory we can filter that list by views that use the iiif manifest views style plugin. Would def cut the size of that list down. |
Yeah, or it would be good to more clearly define that this is a list of views and you are supposed to select one that gives the IIIF Manifest for a resource. Also that the default provided is IIIF Manifest |
@whikloj Everything's been reverted to point to 8.x branches. This is ready to go. |
Testing one last time. |
Mine just spun up successfully 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Paged content config * Setting up sequence mode and the reference strip * Testing autodetecting sequence mode * Missed an inventory var * Using new theme with better dependencies * Setting iiif view in post-install.yml for better caching * Pointing back to 8.x branches * Update drupal.yml
GitHub Issue: Islandora/documentation#932
What does this Pull Request do?
This pulls together all the config needed for the work from the Paged Content sprint. It ties together all the great work from everyone. Plus it installs a few extra things we've collected over time but aren't installed by default (oai-pmh and breadcrumbs). Also:
admin_toolbar
.What's new?
Paged content!
How should this be tested?
vagrant up
Interested parties
Fun one to test that shows all the great work the community has done! @Islandora-Devops/committers @rangel35 @dbernstein @elizoller @manez