Issue 1309

[dannylamb]

GitHub Issue: Islandora/documentation#1309

For testing Islandora/islandora#761

What does this Pull Request do?

Pulls in code for Islandora/islandora#761 so it can be tested.

What's new?

Islandora depending on drupal/transliterate_filenames

How should this be tested?

• Try to upload a file with a comma or a square bracket in it.
• Feel the pain and heartbreak because your file gets rejected
• Pull in this PR
• vagrant up
• Try to upload a file with a comma or a square bracket in it.
• Let your heart fill with joy because your filename got sanitized on the way in, and are now acceptable.

Interested parties

@Islandora-Devops/committers

[seth-shaw-unlv]

See this comment: Islandora/islandora#761 (comment)

[dannylamb]

@seth-shaw-unlv Ok, I've added the module to the appropriate variables in the webserver role. Islandora/islandora#761 now just adds the module to the "suggests" block. So we "suggest" you use that module, and if you install with our installer... you get it :)

[seth-shaw-unlv]

I can probably spin this one up in a few minutes.

[seth-shaw-unlv]

This works as advertised.

My only concern is that we don't auto-populate the Original Name field and some users might be confused why their filename changed. That said, we can move forward with this so repositories don't break and document why we are doing this.

[dannylamb]

Lets make an issue for that if we don't already have one.