Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geerlingguy versions #173

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Conversation

DonRichards
Copy link
Member

GitHub Issue: Islandora/documentation#1343
The build fails to build. Looks like a version problem.

What does this Pull Request do?

Updates 3 roles geerlingguy.php, geerlingguy.php-versions, geerlingguy.mysql

What's new?

geerlingguy.php -> v4.0.0
geerlingguy.php-versions -> v4.0.0
geerlingguy.mysql -. v3.1.0

How should this be tested?

Remove external roles, build and get a fail

$ vagrant destroy -f
$ rm -rf roles/external/*
$ vagrant up

Remove external roles, switch to this PR, build again and it will pass

$ vagrant destroy -f
$ rm -rf roles/external/*
# switch to this PR
$ vagrant up

Additional Notes:

N/A

Interested parties

@Islandora-Devops/committers

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My build works without this PR and it also works with this PR. So I'm fine merging this just to update the dependency.

@whikloj whikloj merged commit e9e6321 into Islandora-Devops:dev Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants