Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull latest karaf version #176

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Pull latest karaf version #176

merged 1 commit into from
Sep 4, 2020

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Apr 14, 2020

GitHub Issue: n/a

What does this Pull Request do?

Makes the dev branch pull the most recent version from maven, which is overridden anyways because we build it from source.

At a release we probably don't want to build from source and instead pin this variable to a specific maven version of Alpaca.

How should this be tested?

  1. Build the islandora-playbook
  2. Then go into the vm vagrant ssh
  3. Goto cd /opt/maven/repo/ca/islandora/alpaca/
  4. In all of the subdirectories you should have a 1.0.3 directory.

Interested parties

@Islandora-Devops/committers

@elizoller
Copy link
Member

Pulled down PR, merged with dev branch, vagrant up with ubuntu/bionic64, check alpaca version - it is 1.0.3
success! and much better than having to manually iterate this when building.
@whikloj do you want to update your branch with dev?

Copy link
Member

@elizoller elizoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the branch is merged with dev, this works as advertised. received 1.0.3 upon installation.

@rosiel
Copy link
Contributor

rosiel commented Sep 4, 2020

Since "this branch has no conflicts with the base branch", I don't think @whikloj has to do anything for it to work.

However, if you were testing, and pulled this on top of a more updated dev branch, then you would have had to do a merge commit locally, to combine (smoothly, I would expect!) the updated dev branch with this PR's changes.

@elizoller feel free to merge!

@elizoller elizoller merged commit e61c368 into dev Sep 4, 2020
@whikloj whikloj deleted the alpaca-repo branch September 8, 2020 12:52
@whikloj
Copy link
Member Author

whikloj commented Sep 8, 2020

Sorry folks, this fell off my radar. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants