-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Drupal 10. #105
Use Drupal 10. #105
Conversation
Draft until we sort out the HEADER_X_FORWARDED_ALL is deprecated thing in the site template. |
Also, we need Matomo to fix this known issue where it can't install from existing configs because as of Drupal 10.1, the user module doesn't get installed first and so user roles aren't available in modules' install functions. Explanation. Ticket in matomo. |
I've isolated the error messages to a line in the Site Template, and created an issue and a pull request Islandora-Devops/isle-site-template#7. |
The associated PR mentioned above has been merged, so this is now good for testing/merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke test works:
- Empty site template, used the PR branch.
docker compose --profile dev up -d
- Inside the docker drupal container:
composer install
- Update the
settings.php
according to the instructions - Cleared cache
Drupal status page shows Drupal 10 and I can add new items with media. 👍
Anything else we need to do before merging?
Launch site with Drupal 10.
config_update
andcontext
at non-stable versionsNote: Drush 12 "doesn't work with the launcher" so after an update (at least) you need to invoke it with
vendor/bin/drush
rather than justdrush
. This is annoying but I don't know how to remedy it, or if it's a starter-site problem or isle-site-template problem.