Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove REST OAI-PMH patch now in core module #90

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Remove REST OAI-PMH patch now in core module #90

merged 4 commits into from
Jun 12, 2023

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Jun 2, 2023

The issue the patch in this composer.json referenced is now in REST OAI-PMH, which this PR also updates to the latest version.

$ git clone git@github.com:Islandora-Devops/isle-dc.git
$ cd isle-dc
$ make starter
...
...
Applying patches for drupal/rest_oai_pmh
    https://www.drupal.org/files/issues/2022-06-01/mods_view_render.patch (View render issue #3283661)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2022-06-01/mods_view_render.patch
 ...
 ...

Also, while creating a new release for REST OAI-PMH (to add d10 support), the mods.html.twig from this repo was accidentally added to the core module (I didn't realize composer was copying that file into the module where my checked out copy was). I can remove that TWIG template if desired, or the patch can be removed from here. This PR also has the patch removed.

@joecorall joecorall changed the title Remove patch now in core module Remove REST-OAI patch now in core module Jun 2, 2023
@joecorall joecorall changed the title Remove REST-OAI patch now in core module Remove REST OAI-PMH patch now in core module Jun 2, 2023
@joecorall joecorall marked this pull request as ready for review June 4, 2023 21:45
@Natkeeran
Copy link
Contributor

@joecorall

As noted in the slack, if you are planning on leaving the extended template in the core, yes, it can be removed from the composer script here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants