-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newspaper Issues Calendar View #91
base: main
Are you sure you want to change the base?
Conversation
Once we add this (this pr's ok, i'll make a follow-up) we can remove views nested details, right? |
Accessibility testing? |
1 - my test with voiceover found it impossible to access the individual days, unless you tab across each date, and even in that case, the coloured highlighting is inaudible. There are more tweaks i'd propose - including making this the default newspaper view or available in an alternate rendering while keeping the same breadcrumbs - but the accessibility piece is the big one. |
01741d7
to
579d80a
Compare
Upgrade fullcalendar_solr version to 1.0.0-beta6
An update on the accessibility issues, I've updated the PR to use the latest release of the FullCalendar Solr module. This version has improved accessibility:
Accessibility testing was done using WebAIM WAVE and Axe DevTools. In addition to the accessibility improvements, there is an added option to link to the item if the date has only one result. |
Great. I noticed you're using the Date Created field. In the other newspaper view, we use Date Issued (which is also what the sample content has). |
The calendar view now uses the Date Issued field instead of Date Created. |
Changes: - Calendar Link block redirects to the latest year with results - Enable option to link to option if date has only one result
I updated the Calendar Link block to redirect to the latest year with results. Also, enabled the option to link directly to the issue if a date has only one result. |
This PR installs the fullcalendar_solr module and provides a calendar view for newspaper collections.
It includes: