Remove requirement for resource type.

[rosiel]

Pursuant to Islandora/documentation#2052, this PR changes system actions to not require the Resource Type field. It also makes the field multivalued and not required.

[noahwsmith]

I think this will break a number of assumptions of the https://github.com/Islandora-Devops/islandora_starter_theme but I'd have to really test it to find out. I will try to get feedback for this soon...

[rosiel]

There is no reference to the regex resource.type in the starter or base theme.

[noahwsmith]

@dannylamb could you please take a look at this?

[rosiel]

Testing Instructions:

1. Get a copy of isle-dc.
2. Edit this line to git clone -b 2052-use-pr-branch https://github.com/islandora-devops/islandora-sandbox (the -b part is new)
3. Since 2052-use-pr-branch points to my PR branch, doing a launch of isle dc should work to pull in this PR.

[seth-shaw-unlv]

It looks like something else may be missing in this setup. I've run make clean; make local-install-profile with the Makefile update to pull the branch, but it keeps failing on SOLR:

In SolrCommandHelper.php line 119:

  Unknown server default_solr_server




ERROR: Could not generate SOLR config.zip!
In Drupal, check Configuration -> Search API -> SOLR Server, and use the
+ Get config.zip option which should give you information into the actual error.


make[1]: *** [Makefile:167: solr-cores] Error 1
make[1]: Leaving directory '/home/sshaw/isle-dc'
make: *** [Makefile:398: local-install-profile] Error 2

Which version of isle-dc or the image tags are you using, @rosiel?

[noahwsmith]

This may be hard to test before this PR is accepted, which addresses some order of operation issues
Islandora-Devops/isle-dc#248

[noahwsmith]

Previous change to address context change to remove hardcode requirement for resource type

[noahwsmith]

This Issue was picked as part of an IslandoraCon 2022 Use-A-Thon project - more info here https://docs.google.com/document/d/17rkEzgFjxv5WCVmt-MqZLXYcvO4z658zs5hG9SP2FmQ/edit#

Current status is that I have worked through all of these settings in my local, and achieved a full working state that does not require Resource Type (or use it for any context). I'd like to test this on a rebuilt local before I turn this over to others for testing...

[noahwsmith]

Updating Rosie's previous review instructions:

1. Get a copy of isle-dc.
2. Edit sample.env to read TAG=1.0.7 instead of TAG=1.0.0-alpha-16 if it does not already.
3. Edit this line to git clone https://github.com/islandora-devops/islandora-sandbox -b 2052-use-pr-branch /tmp/codebase (the -b is changed from main).
4. Since 2052-use-pr-branch points to my PR branch, doing a launch of isle dc should work to pull in this PR. Run make local
5. To get some sample data, run a subsequent make demo_content

Test criteria: ensure that all types of content display as expected, that search is not broken, and that all ingests from the demo_content import succeed.

My test results: everything works great except for Newspapers. I will go another round on those, especially since I see the same issues in @ysuarez 's new install and I can work on both things at once.

[rosiel]

The PR is currently failing to do a drush site-install, i'm testing whether this is the line that's causing (sorry for misremembered wording) "Config could not be enabled."

[noahwsmith]

Hi Rosie - I'm not able to replicate this. Did you run make local which contains docker-compose exec -T drupal with-contenv bash -lc "drush si -y islandora_install_profile_demo --account-pass $(shell cat secrets/live/DRUPAL_DEFAULT_ACCOUNT_PASSWORD)" or a different function?

[noahwsmith]

Ok, part of the Newspaper problem was related to Ghostscript not being present on the 1.0.0-alpha-16 containers. This is fixed in latest containers, so I pushed this change and will re-test with the latest containers.

Islandora-Devops/isle-dc#285