Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Collections View #32

Merged
merged 4 commits into from
Dec 26, 2022
Merged

Fix Collections View #32

merged 4 commits into from
Dec 26, 2022

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Dec 1, 2022

Ticket: #31

To test this, you MUST install this exact version (not update to it, etc). Use this branch of the sandbox to deploy. (In its README there are testing instructions).

With this PR:

  • The Collections view now filters on the core Model field, instead of the metadata-y Resource Types field.
  • The Context for displaying Collections now 'includes default blocks' (it looked a little weird without it)
  • The Context module's no longer locked to a specific commit, to fix a warning i was getting (Context module: "Menu Reactions" will not work because menu.active_trail has a different menu service provider.)
  • For good measure (this is NOT active in the current install, see ticket #31 ), removed the core Islandora tags from this list, and corrected the Collection tag. This is so that we can use this file in the future if/when we remove Defaults.

@noahwsmith
Copy link
Contributor

Full install trace: https://gist.github.com/noahwsmith/3ac13b9582a5fc7fa23cecd527a5d610

Looks good! My test collection shows on the "Browse Collections" page if the Model is "Collection" and it doesn't care about the Resource Type.

Screenshot 2022-12-02 at 10 11 28 AM

I'm happy to approve this for merging, but it sounds like there's a specific order of ops for Islandora-Devops/islandora-sandbox#19. I'm comfortable with you merging all those things in the correct order with the correct edits, @rosiel , if you're willing.

Thanks for doing this!

@noahwsmith noahwsmith self-requested a review December 2, 2022 15:14
Copy link
Contributor

@noahwsmith noahwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great for me!

@rosiel
Copy link
Contributor Author

rosiel commented Dec 3, 2022

Great! The order of ops is:

  • merge this
  • update the linked sandbox PR (repoint the composer.json file, then update composer.lock)
  • merge the sandbox pr

@alxp alxp merged commit e7e50e8 into Islandora-Devops:main Dec 26, 2022
@rosiel rosiel deleted the fix-collections branch December 26, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants