Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the introduction to redirect users to better starting points … #164

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

nigelgbanks
Copy link
Contributor

…in case they ended up at this repo by accident.

To address #162

…in case they ended up at this repo by accident.
@nigelgbanks nigelgbanks requested a review from rosiel December 13, 2021 20:43
@rosiel
Copy link
Contributor

rosiel commented Dec 14, 2021

😻 thanks Nigel. Sorry I didn't see this earlier.

Assuming the same problem with the build as with #171, i'm merging.

@rosiel rosiel merged commit ed93c0a into main Dec 14, 2021
@rosiel rosiel deleted the issue-162-documentation branch December 14, 2021 02:30
@DonRichards
Copy link
Member

@nigelgbanks Looks good thanks!!

rosiel added a commit that referenced this pull request Jan 5, 2022
* Fix logging errors with cantaloupe due to find/replace bug (#165)

* Adding max_input_vars to php.ini (#166)

* Explain how Docker Hub factors in the workflow. (#171)

* Updated the introduction to redirect users to better starting points in case they ended up at this repo by accident. (#164)

* [issue-172] Use explicit commits in URLs such that (#176)

Code can change when pulling from a master branch, which causes checksum
checks to fail.

This can changes master to instead refer to explicit commits hashes.

The output docker images is byte for byte the same though.

* Prevent passwords from being logged.

Co-authored-by: dannylamb <dlamb@islandora.ca>
Co-authored-by: Rosie Le Faive <lefaive@gmail.com>
rosiel added a commit that referenced this pull request Feb 10, 2022
* Fix logging errors with cantaloupe due to find/replace bug (#165)

* Adding max_input_vars to php.ini (#166)

* Explain how Docker Hub factors in the workflow. (#171)

* Updated the introduction to redirect users to better starting points in case they ended up at this repo by accident. (#164)

* [issue-172] Use explicit commits in URLs such that (#176)

Code can change when pulling from a master branch, which causes checksum
checks to fail.

This can changes master to instead refer to explicit commits hashes.

The output docker images is byte for byte the same though.

* Prevent passwords from being logged.

Co-authored-by: dannylamb <dlamb@islandora.ca>
Co-authored-by: Rosie Le Faive <lefaive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants