Matomo upgrade 4151 #284
Matomo upgrade 4151 #284
Conversation
|
Hmm @nigelgbanks do you want to try this and see if you get the same error? #0 3.341 16950K .......... .......... .......... .......... .......... 99% 4.16M 0s
#0 3.352 17000K .......... .......... .......... .......... .......... 99% 47.2M 0s
#0 3.353 17050K .......... .......... .......... .......... .......... 99% 23.5M 0s
#0 3.356 17100K ... 100% 6.21T=2.8s
#0 3.356
#0 3.356 2023-08-04 19:57:44 (6.05 MB/s) - '/opt/downloads/matomo-4.15.1.tar.gz' saved [17513813/17513813]
#0 3.356
------
ERROR: failed to solve: executor failed running [/bin/bash -euo pipefail -c download.sh --url "${MATOMO_URL}" --sha256 "${MATOMO_SHA256}" --strip --dest /var/www/matomo && wget --directory-prefix=/var/www/matomo "https://raw.githubusercontent.com/matomo-org/matomo/${MATOMO_VERSION}/composer.json" && wget --directory-prefix=/var/www/matomo "https://raw.githubusercontent.com/matomo-org/matomo/${MATOMO_VERSION}/composer.lock" && composer require -d /var/www/matomo symfony/yaml:~2.6.0 && composer require -d /var/www/matomo symfony/process:^5.4 && composer install -d /var/www/matomo && download.sh --url "${EXTRA_TOOLS_URL}" --sha256 "${EXTRA_TOOLS_SHA256}" --strip --dest /var/www/matomo/plugins/ExtraTools && curl https://download.db-ip.com/free/dbip-city-lite-`date +%Y`-`date +%m`.mmdb.gz > /tmp/dbip.mmdb.gz && gunzip -f /tmp/dbip.mmdb.gz && mv /tmp/dbip.mmdb /var/www/matomo/misc/DBIP-City.mmdb && cleanup.sh]: exit code: 123
make: *** [bake] Error 1Not clear where the failure is. |
|
FYI this was checked out from #278 and refreshed with latest |
|
Okay human error on my part. Wrong SHA will make things break and me a dull boy. Built on local with new SHA & Pushed for review. |
|
@g7morris We looked at this PR during the tech call today. |
matomo/Dockerfile
Outdated
| composer install -d /var/www/matomo && \ | ||
| download.sh \ | ||
| --url "${EXTRA_TOOLS_URL}" \ | ||
| --sha256 "${EXTRA_TOOLS_SHA256}" \ | ||
| --strip \ | ||
| --dest /var/www/matomo/plugins/ExtraTools && \ | ||
| curl https://download.db-ip.com/free/dbip-city-lite-`date +%Y`-`date +%m`.mmdb.gz > /tmp/dbip.mmdb.gz && \ |
There was a problem hiding this comment.
The dbip-city-lite download URL is based on the current date. This means that every build potentially downloads a different file, which is not reproducible.
This will also negatively affect build caches for the same reason.
From https://matomo.org/faq/how-to/faq_163/
Matomo includes a tool that will download the IP to City Lite database for you. You can access the tool by navigating to Settings > Geolocation.
...
Note: The latest version of Matomo includes an auto-updater for these databases.
The IP data should be fetched at runtime using the mechanism Matomo already provides, this data should be either stored in a volume or the database (also a volume)?
There was a problem hiding this comment.
Agreed. We're going to take a look at your suggestions here and propose updates to follow shortly. Thanks for hanging in on this.
|
Hi folks, Thanks for your continued patience. I have currently been on a long vacation and am just coming back now to these great questions and comments. I'll get some traction next week including answering @ysuarez and @nigelgbanks |
|
Okay @nigelgbanks I think this is what was needed right? Pulled the monthly update out and we're ready to merge no? |
g7morris
force-pushed
the
matomo-upgrade-4151
branch
from
ee8038d to
1ebea50
Compare
No description provided.