Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Updated alpine to 3.19.1 #330

Merged
merged 7 commits into from
Apr 10, 2024
Merged

[minor] Updated alpine to 3.19.1 #330

merged 7 commits into from
Apr 10, 2024

Conversation

nigelgbanks
Copy link
Contributor

  • Custom nodejs package to support code-server.
  • Update imagemagick / leptonica.
  • PHP/FPM 8.3

- Custom nodejs package to support code-server.
- Update imagemagick / leptonica.
- PHP/FPM 8.3
@nigelgbanks nigelgbanks mentioned this pull request Mar 29, 2024
@nigelgbanks nigelgbanks marked this pull request as ready for review April 2, 2024 16:17
@nigelgbanks nigelgbanks requested a review from aOelschlager April 2, 2024 17:00
@aOelschlager aOelschlager requested a review from alxp April 3, 2024 17:25
@alxp
Copy link
Contributor

alxp commented Apr 9, 2024

I tried to build this using the latest 'development' branch of ISLE-DC and it started printing out this waiting message until it failed, this happened twice after clean builds on macOS Sonoma 14.4.1.

al.php
  - Copy [web-root]/sites/example.sites.php from assets/scaffold/files/example.sites.php
  - Copy [web-root]/sites/default/default.services.yml from assets/scaffold/files/default.services.yml
  - Copy [web-root]/sites/default/default.settings.php from assets/scaffold/files/default.settings.php
  - Copy [web-root]/modules/README.txt from assets/scaffold/files/modules.README.txt
  - Copy [web-root]/profiles/README.txt from assets/scaffold/files/profiles.README.txt
  - Copy [web-root]/themes/README.txt from assets/scaffold/files/themes.README.txt
Scaffolding files for islandora/islandora-starter-site:
  - NOTICE Creating a new file at [web-root]/sites/default/settings.php. Examine the contents and ensure that it came out correctly.
  - Append to [web-root]/sites/default/settings.php from assets/patches/default_settings.txt
/Library/Developer/CommandLineTools/usr/bin/make starter-finalize ENVIRONMENT=starter_dev
docker compose exec -T drupal with-contenv bash -lc 'chown -R nginx:nginx . ; echo "Chown Complete"'
Chown Complete
/Library/Developer/CommandLineTools/usr/bin/make drupal-database update-settings-php
Waiting for nginx and php-fpm
Waiting for nginx and php-fpm
Waiting for nginx and php-fpm
Waiting for nginx and php-fpm
Waiting for nginx and php-fpm
Waiting for nginx and php-fpm
Waiting for nginx and php-fpm
Waiting for nginx and php-fpm
Waiting for nginx and php-fpm
Waiting for nginx and php-fpm
Waiting for nginx and php-fpm

@aOelschlager
Copy link
Contributor

@alxp I'm sorry, I forgot about that part in isle-dc. This line would need to change for php 8.3: https://github.com/Islandora-Devops/isle-dc/blob/development/Makefile#L117

@alxp
Copy link
Contributor

alxp commented Apr 10, 2024

OK I'll try and run the build again will likely happen after work today.

@alxp
Copy link
Contributor

alxp commented Apr 10, 2024

I just tested the ISLE-DC build after fixing the PHP version and it builds and I get the Drupal site.

@aOelschlager
Copy link
Contributor

Thank you @nigelgbanks and @alxp!

@aOelschlager aOelschlager merged commit 997a932 into main Apr 10, 2024
76 checks passed
@nigelgbanks nigelgbanks deleted the issue-329 branch April 10, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants