Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solr: Add OCR Highlight plugin. #338

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Solr: Add OCR Highlight plugin. #338

merged 2 commits into from
Jun 5, 2024

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Jun 4, 2024

The build will fail if there is a problem downloading the file, otherwise you can just look for the presence of the downloaded .jar file in the above location.## What does this pull request do?

Adds the OCR Highlighting plugin to the Solr image.

The jar is placed in a directory where Solr won't find it unless it is explicitly configured to do so, which Drupal sites that are set up to support Solr and hOCR will do. But otherwise the presence of the .jar in the

/opt/solr/server/solr/contrib/ocrhighlighting/lib/solr-ocrhighlighting-0.8.6.jar

folder will have no effect.

How should this be tested?

Copy link
Contributor

@nigelgbanks nigelgbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the two issues I highlighted, this looks ready to go in.

solr/Dockerfile Outdated Show resolved Hide resolved
solr/Dockerfile Outdated Show resolved Hide resolved
@nigelgbanks nigelgbanks merged commit 86d098d into main Jun 5, 2024
76 checks passed
@nigelgbanks nigelgbanks deleted the solr-ocrhighlight branch June 5, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants