Remove no-op multistage builds from Dockerfiles #379
Conversation
There was a problem hiding this comment.
These aren't as they appear, as they're getting aliased in docker-bake.hcl e.g. https://github.com/Islandora-Devops/isle-buildkit/blob/main/docker-bake.hcl#L315-L322
They get built in separate repos e.g. https://github.com/Islandora-Devops/isle-nodejs
Semi-related: I have plans to get these auto-updated using renovate and have the FROM in dockerfiles be better documented avoiding confusion such as this PR, but haven't had time to put up that PR yet. I started a while ago over at https://github.com/joecorall/isle-buildkit but it's nowhere close to ready. I should have time to push that forward this week
|
Also, the images do get used in the build e.g isle-buildkit/code-server/Dockerfile Line 38 in 50fa27d |
@joecorall Before you sink time into that, those repositories are likely to be merged into the isle-buildkit. I've solved a number of the caching issues, which was the reason they were split into their own repositories in the first place. I'm still working away it maybe another week or two before I'm ready with a pull request, though. |
|
Thanks so much for documenting and closing this, and apologies for any bother! Much appreciate the insight. |
NB: I may be misunderstanding the intended outcome so please verify my proposed change carefully 😄
AFAICT, a
FROMstatement without a followingas <name>, as seen here, will have no effect on the built image. (I expect the image gets pulled, but that seems like a side-effect here, not an output?)So - I think these extra FROM are redundant and can be discarded. My understanding is that if they were followed by a name (
FROM nodejs as node) and had separate build instructions, that would be a multi-stage build, but that as-is these are a multi-stage build with a single output, and that the state is cleared when the second FROM command is reached.