Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo startup. #77

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Fix demo startup. #77

merged 1 commit into from
Oct 1, 2020

Conversation

nigelgbanks
Copy link
Contributor

@nigelgbanks nigelgbanks commented Oct 1, 2020

Potentially temporary fix for change introduced Islandora/controlled_access_terms#54.

> drush fim --no-interaction --yes controlled_access_terms_defaults

In FieldStorageConfigStorage.php line 174:
                                                                                                
  Unable to determine class for field type 'name' found in the 'field.storage.0' configuration  
                                                                                                

In DiscoveryTrait.php line 53:
                                                                                                                            
  The "name" plugin does not exist. Valid plugin IDs for Drupal\Core\Field\FieldTypePluginManager are: comment, typed_rela  
  tion, edtf, authority_link, datetime, file, file_uri, geolocation, image, link, list_float, list_string, list_integer, p  
  ath, text_long, text_with_summary, text, decimal, entity_reference, string, uuid, boolean, map, changed, created, passwo  
  rd, float, language, string_long, integer, email, uri, timestamp   

Which removed the dependency on the name module by splitting the features configuration into install/optional and allowing users to manually select in the Features UI to not install optional dependencies. Unfortunately drush features:import doesn't expose this functionality. So for now we do not import those features which is the same route the playbook took: https://github.com/Islandora-Devops/islandora-playbook/pull/190/files.

Without this change it's not possible to start the demo site.

@nigelgbanks nigelgbanks requested a review from dannylamb October 1, 2020 13:04
@seth-shaw-unlv
Copy link

That is a permanent fix. You don't need to feature import the controlled_access_terms_defaults. Simply installing the module gives you everything you need.

@seth-shaw-unlv
Copy link

We needed to fix the playbook (Islandora-Devops/islandora-playbook#190) but I didn't even think about ISLE needing a similar fix.

@dannylamb
Copy link
Member

...and now I'm magically running into this. Testing now.

@dannylamb
Copy link
Member

@seth-shaw-unlv A lot of what we do mirrors the playbook here. But a lot of that is gonna go when we change things so you build your own Drupal container, though. So for the time being they're kinda linked.

@dannylamb
Copy link
Member

We're good. This gets the init script completing again.

@dannylamb dannylamb merged commit 52b770a into Islandora-Devops:main Oct 1, 2020
@nigelgbanks nigelgbanks deleted the fix-demo-startup branch October 21, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants