Skip to content

Commit

Permalink
Merge pull request #3 from birkland/windows-path-compat
Browse files Browse the repository at this point in the history
Fix paths on Windows + git bash
  • Loading branch information
nikathone authored Apr 1, 2020
2 parents 1da4ce9 + 3ee03e8 commit 7819a6f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ solr_init:
./scripts/solr/create-core.sh

up:
docker-compose -p $(docker_compose_project) up --remove-orphans --detach
MSYS_NO_PATHCONV=1 docker-compose -p $(docker_compose_project) up --remove-orphans --detach

build:
docker-compose -p $(docker_compose_project) up \
MSYS_NO_PATHCONV=1 docker-compose -p $(docker_compose_project) up \
--build \
--detach \
--remove-orphans
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Currently there are blank `.keep` files in most of the `config/service` director

* Desktop / laptop / VM
* Docker-CE 19.x+
* If using Docker Desktop for Windows, any stable release *after* 2.2.0.4, or use a 2.2.0.4 with a [patch](https://download-stage.docker.com/win/stable/43542/Docker%20Desktop%20Installer.exe) due to a [bug](https://github.com/docker/for-win/issues/6016)
* Docker-compose version 1.25.x+
* Git 2.0+

Expand Down
2 changes: 1 addition & 1 deletion scripts/drupal/init.sh
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ if [[ ! $composer ]]; then
if $is_darwin; then
composer="docker container run -it --rm --user $UID:$GUID -v $HOME/.composer:/tmp -v $PWD:/app composer:1.9.3"
else
composer="docker container run -t --rm --user $UID:$GUID -v $HOME/.composer:/tmp -v $PWD:/app composer:1.9.3"
composer="env MSYS_NO_PATHCONV=1 docker container run -t --rm --user $UID:$GUID -v $HOME/.composer:/tmp -v $PWD:/app composer:1.9.3"
fi
fi

Expand Down
4 changes: 3 additions & 1 deletion scripts/solr/create-core.sh
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
docker-compose -p islandora exec solr /opt/solr/bin/solr create -c islandora
#!/bin/bash

env MSYS_NO_PATHCONV=1 docker-compose -p islandora exec -T solr /opt/solr/bin/solr create -c islandora

0 comments on commit 7819a6f

Please sign in to comment.