Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toronto is still coming up as default timezone not UTC. #27

Closed
g7morris opened this issue Apr 16, 2020 · 3 comments
Closed

Toronto is still coming up as default timezone not UTC. #27

g7morris opened this issue Apr 16, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@g7morris
Copy link
Collaborator

Toronto is still coming up as default timezone not UTC for the newly created Drupal site when resetting admin password.

@g7morris g7morris added bug Something isn't working POST-MERGE labels Apr 16, 2020
@g7morris
Copy link
Collaborator Author

@nikathone Some history from our PR convo

"The process for checking the timezone comes up when I run docker-compose -p islandora exec drupal drush uli, copy the drush uli generated login reset link and open the url in a new browser, change the password and then scroll down to see the timezone which is stuck on Toronto. I'll rebuild in a few moments and put a screenshot up."

@g7morris
Copy link
Collaborator Author

@nikathone Just an FYI that I see this error when I run make

[Warning] One or more build-args [PHP_DATE_TIMEZONE] were not consumed

Feels like these might be related no?

@nikathone
Copy link
Member

nikathone commented Apr 30, 2020

@g7morris yes and no. The build args warning is because I didn't add ARG PHP_DATE_TIMEZONE=UTC in stage 3 inside the drupal.Dockerfile.

The default timezone being Toronto is coming from Drupal config (see the codebase/sync/system.date.yml file) which might need to update.
Screen Shot 2020-04-30 at 4 50 52 PM

Setting ARG PHP_DATE_TIMEZONE=UTC inside drupal.Dockerfile won't fix this but it ensure that the default php date timezone is also UTC.

Let me know if I should go ahead and create a PR to update drupal.Dockerfile to include ARG PHP_DATE_TIMEZONE=UTC which will suppress the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants