Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The drupal.Dockerfile still using registry.gitlab.com/nikathone/drupal-docker-good-defaults/php-nginx:latest for php and nginx base image #34

Closed
g7morris opened this issue Apr 16, 2020 · 2 comments
Assignees

Comments

@g7morris
Copy link
Collaborator

Per @nikathone's comment here #6

"The drupal.Dockerfile still using registry.gitlab.com/nikathone/drupal-docker-good-defaults/php-nginx:latest for php and nginx base image but this will change once we have a CI to build images/nginx-php/Dockerfile."

@nikathone Can we make an official Islandora version of this post-merge? We now have control over the Islandora Dockerhub account to be able to push images. We can also make a new repo accordingly if need be too. Your thoughts?

@g7morris
Copy link
Collaborator Author

g7morris commented May 6, 2020

@dannylamb Have you made a new Github repo and Dockerhub image from this?

@g7morris g7morris assigned dannylamb and unassigned g7morris May 6, 2020
@dannylamb
Copy link
Member

Yeah, I can update that. I'm rocking the new repo now in my fork and everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants