Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #304

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Update README.md #304

merged 2 commits into from
Nov 25, 2022

Conversation

DonRichards
Copy link
Member

Updates a few items on the README

  • Adds a column to indicate what is exposed by default
  • Corrects a URL indicated for Solr
  • Adds consistency with make command references (where a docker-compose command was referenced and could be substituted for a make command).

@DonRichards DonRichards requested a review from rosiel October 26, 2022 18:24
Copy link
Contributor

@rosiel rosiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you throw in a line about where/how/that you're able to change it? (or does that belong elsewhere?) [Edit: or is that sufficiently implied by "by default"? If you'd rather not draw new users to thing they'd be better off not touching, I understand]

@DonRichards
Copy link
Member Author

@rosiel OK, done.

@@ -148,7 +156,7 @@ The former will create a starter site modeled off of https://sandbox.islandora.c
If you already have a Drupal site but don't know how to export it,
log into your server, navigate to the Drupal root, and run the following commands:

- `drush config:export`
- `make config-export`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it at all possible to move a non-ISLE site to ISLE? If so, these instructions seem like the place to look.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forget it. separate issue.

To change a service exposed value edit the *.env* file. The values will start with "EXPOSE_". Make changes then rebuild the docker-compose file and then run the up command (even if it's already running) using the following commands.
```shell
make -B docker-compose.yml
make up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed these instructions and went from a functioning site (starter_dev) to this:

Screen Shot 2022-11-07 at 7 16 48 PM

I have to say the green is pretty, I've never seen it on the Drupal install screen before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same thing happened when i started with a make local site.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Don on the Tech Call: maybe permissions got out of whack.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was caused by the ENVIRONMENT not being set properly in my .env file. 🤦

This is good.

@@ -148,7 +156,7 @@ The former will create a starter site modeled off of https://sandbox.islandora.c
If you already have a Drupal site but don't know how to export it,
log into your server, navigate to the Drupal root, and run the following commands:

- `drush config:export`
- `make config-export`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forget it. separate issue.

To change a service exposed value edit the *.env* file. The values will start with "EXPOSE_". Make changes then rebuild the docker-compose file and then run the up command (even if it's already running) using the following commands.
```shell
make -B docker-compose.yml
make up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was caused by the ENVIRONMENT not being set properly in my .env file. 🤦

This is good.

@rosiel rosiel merged commit 4d1f382 into development Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants