Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.cantaloupe.yml #360

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

joshdentremont
Copy link
Contributor

Changed the port, and added some middleware configuration to Cantaloupe so it works with Buildkit 2.0.0 and higher.

This matches the setup in the site template, and without this Cantaloupe will not work when using buildkit 2.0.0 or higher.

To test, spin up a site using buildkit 2.0.0 or higher and try to access Cantaloupe. You should get a 502 error, which is fixed by the port change, but then you will have a 404 error without the middleware additions. A new site with this change should let you access Cantaloupe as normal.

Changed the port, and added some middleware configuration to Cantaloupe so it works with Buildkit 2.0.0 and higher
Copy link
Contributor

@joecorall joecorall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Received a 502 on cantaloupe on the main branch

$ cd path/to/isle-dc
$ git checkout development
$ git pull origin development
$ make down clean
$ make starter
$ curl -s -o /dev/null -w "%{http_code}" https://islandora.traefik.me/cantaloupe/
502

This PR fixed it

$ cd path/to/isle-dc
$ gh pr checkout 360 --repo Islandora-Devops/isle-dc
$ make down clean
$ make starter
$ curl -s -o /dev/null -w "%{http_code}" https://islandora.traefik.me/cantaloupe/
200

Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it fixed the Cantaloupe error.

@wgilling wgilling merged commit 1a8db05 into Islandora-Devops:development Oct 4, 2023
@rbos
Copy link

rbos commented Nov 2, 2023

You also need - traefik.http.routers.${COMPOSE_PROJECT_NAME-isle-dc}-cantaloupe_http.middlewares=cantaloupe for the oddballs running HTTP-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants