Add php 8.2 // isle-buildkit:3.x support #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aOelschlager
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Islandora-Devops/isle-buildkit#299 bumped the isle-buildkit major version from
2.xto3.xsince that PR upgraded PHP8.1 -> 8.2, and 8.2 could break drupal 9 sites. This PR simply checks if the tag is 3.x and sets the PHP FPM pid file to the correct value. It also bumps the starter site and default isle-buildkit tags to the latest versions.Testing
New functionality
Running this command (which will destroy any site you may have running locally) spins up a d10 site with php 8.2
Regression test
Running this command (which will destroy any site you may have running locally) spins up a d10 site with php 8.1