Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated network option #381

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

ajstanley
Copy link
Contributor

This relates to issue 379.
External is not a recognized Docker network option, but it only fails on some machines. This ought to work anywhere, but its only been tested on a Mac, and an old one at that,

@misilot
Copy link
Contributor

misilot commented Mar 13, 2024

That's weird since external is defined in the documentation: https://docs.docker.com/compose/compose-file/06-networks/#external

@misilot
Copy link
Contributor

misilot commented Mar 13, 2024

Though it looks like the default is internal: false so would it be worth removing that config option all together?

@aOelschlager
Copy link
Contributor

I would agree with @misilot that internal:false can be removed from the yaml files. In the tech call it was mentioned that the original purpose for this (external:true) was to be able to run isle 7 at the same time as isle-dc. I don't know if anyone is using it this way anymore but I highly doubt it.

Copy link
Contributor

@joecorall joecorall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this PR I was getting

$ make starter
...
...
docker compose up -d --remove-orphans
Error response from daemon: network gateway not found
make: *** [starter] Error 1

$ echo $?
2

After this PR make starter gets past the docker compose up -d --remove-orphans command successfully.

@joecorall joecorall merged commit 897e090 into Islandora-Devops:development Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants