Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for config export through UI #390

Merged
merged 7 commits into from
May 1, 2024
Merged

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Apr 24, 2024

Accessing a config export through the Drupal admin UI fails with the default timeout settings in this repo (i.e. hitting this URL >> https://islandora.traefik.me/admin/config/development/configuration/full/export-download << after make starter results in a 5XX error)

Added a test around this proving a set of timeout environment variables are needed to fix the issue.

Also made the nightly build check against the latest version of isle-buildkit

Before

https://github.com/Islandora-Devops/isle-dc/actions/runs/8824402956/job/24226804416?pr=390

After

https://github.com/Islandora-Devops/isle-dc/actions/runs/8824446972/job/24226928240

TODO

Figure out exactly which environment variables we need and only set those.

Links

https://islandora.slack.com/archives/CM6F4C4VA/p1713892169660929?thread_ts=1713892169.660929&cid=CM6F4C4VA

@joecorall joecorall marked this pull request as ready for review April 24, 2024 23:11
Copy link
Contributor

@ajstanley ajstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes worked for me in two different environments.
In both cases I could download config, but in both cases files were left behind in the /tmp directory because Drupal was under the mistaken impression that the files weren't there.
That appears to be a separate issue.

@joecorall
Copy link
Contributor Author

joecorall commented Apr 27, 2024

In both cases I could download config, but in both cases files were left behind in the /tmp directory because Drupal was under the mistaken impression that the files weren't there.

The file being left behind is intended behavior. There is no cleanup that happens after the export

There is an attempt to remove the file before the export happens. This is the cause of the mysterious watchdog entries. When you run the export for the first time there will not be a file there, so that cleanup call will log in watchdog. Then the export runs with no cleanup happening after the fact resulting in puzzled engineers.

Going to issue a PR on Drupal core for this if one doesn't already exist. We've spent several hours tracking this down thinking we may have some odd /tmp side effect in our stack and I know from the tech call @DonRichards has ran into this quandry, too. And a google search says many others have, too.

🤞 https://www.drupal.org/project/drupal/issues/3443874

@ajstanley ajstanley merged commit b2e773f into development May 1, 2024
1 check passed
@ajstanley ajstanley deleted the test-config-export branch May 1, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants