Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to use MySQL persistence instead of File persistence for Fedora #23

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Oct 11, 2023

Provide the necessary environment variables to create a database for fedora.

Related to #21

@joecorall joecorall changed the title Use MySQL persistence instead of File persistence for Fedora Default to use MySQL persistence instead of File persistence for Fedora Oct 11, 2023
@joecorall joecorall marked this pull request as ready for review October 11, 2023 14:44
@rosiel rosiel self-requested a review October 11, 2023 17:34
@rosiel
Copy link
Contributor

rosiel commented Oct 19, 2023

This appears to be working much better. WRT the problems in #21,

  • There's a db in mariadb called fcrepo and its' getting populated.
  • After adding a node, i can see it in Fedora
  • I can add media to file fields that write to Fedora.

I assume this was just an oversight before? I'm hesitant to merge because I don't understand why this stopped working or whether it wasn't working to begin with. @nigelgbanks any insight?

@nigelgbanks
Copy link
Contributor

Could be a volume / restart thing?

I don't know what Fcrepo is doing internally for its file backend. For example, it may create a file as a lock mutex, to control concurrent access to its file backed database. If restarted, the file lock may still be present, on the volume as Fcrepo rarely shutdowns gracefully, but the process using it as a lock has disappeared, so no new connections to its file backed database could happen? Or a needed file isn't captured by a volume and, as such, a restart causes some sort of data loss / race condition.

Though that's just speculation....

This is definitely safe to merge though.

@nigelgbanks nigelgbanks merged commit b5f9ca3 into Islandora-Devops:main Oct 19, 2023
@joecorall joecorall deleted the fcrepo-mysqp-persistence branch October 19, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants