Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Tag based migrations so that we get Mirador term and there's less reason to fork site template. #38

Merged
merged 1 commit into from
May 1, 2024

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented May 1, 2024

We used to run islandora migrations as a "group" but (to simplify greatly) Drupal stopped supporting migration groups. What we should be using now are tags. Most islandora migrations are tagged with "islandora".

However at some point, we made the (IMO, wrong) choice to not use tags in the site template but to name the migrations that we wanted to run.

This prevents other modules - like islandora mirador - from creating migrations that need to get run during provisioning.

This PR makes the Site Template on par with ISLE-DC by running the migrations with --tag=islandora. In practice, this means you'll get the Mirador term in the "Islandora Display" vocabulary.

It would be good to make more people aware that "we run migrations tagged with islandora on provisioning` to empower people to do what they want to without having to fork our provisioning systems.

@seth-shaw-asu seth-shaw-asu self-requested a review May 1, 2024 17:22
@seth-shaw-asu seth-shaw-asu merged commit 3dff5aa into main May 1, 2024
@rosiel rosiel deleted the tags-based branch May 1, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants