removed matomo from docker-compose.yml #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joecorall
requested changes
Jun 3, 2024
There was a problem hiding this comment.
LGTM. Just blocking this to merge until Islandora-Devops/islandora-starter-site#153 merges to avoid matomo 404's for new isle-site-template installs before that PR merges
|
@joshdentremont - on second pass, there's a few other places matomo is mentioned should also remove in this PR: https://github.com/search?q=repo%3AIslandora-Devops%2Fisle-site-template%20matomo&type=code |
|
@joecorall Good catch. I have removed them all except the vscode spell checker bit, which I figured was safe to leave in as a courtesy to anyone who wants to use it. |
nigelgbanks
approved these changes
Jun 5, 2024
joecorall
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should cover #41