Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address https://github.com/Islandora-CLAW/CLAW/issues/951. #7

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Address https://github.com/Islandora-CLAW/CLAW/issues/951. #7

merged 2 commits into from
Oct 11, 2018

Conversation

mjordan
Copy link
Contributor

@mjordan mjordan commented Oct 10, 2018

Removes no-longer-used lines from migrate_plus.migration.islandora_basic_image.yml related to the destination of the MODS datastream content.

To test:

  1. Check out this branch
  2. Configure and install the migrate_7x_claw module as usual
  3. Run a migration. There should be no side effects.

@mjordan mjordan mentioned this pull request Oct 10, 2018
Closed
@whikloj
Copy link
Member

whikloj commented Oct 10, 2018

This can go as well, doesn't look to be referenced anywhere else.
https://github.com/Islandora-Devops/migrate_7x_claw/blob/master/modules/islandora_migrate_7x_claw_feature/config/install/migrate_plus.migration.islandora_basic_image.yml#L57-L60

@dannylamb
Copy link
Member

@mjordan I can test this now

@dannylamb
Copy link
Member

Yup, no explosions. :shipit:

@dannylamb dannylamb merged commit 6bfed5a into Islandora-Devops:master Oct 11, 2018
@mjordan
Copy link
Contributor Author

mjordan commented Oct 11, 2018

Thanks!

@mjordan mjordan deleted the issue-951 branch October 11, 2018 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannylamb dannylamb dannylamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjordan @whikloj @dannylamb