-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline #35
Pipeline #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be dropping the Gradle version here, unless there is some rationale that I don't understand. Can you back out the Gradle version changes, and keep it at what it was before?
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-3.0-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-bin.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What the reason for dropping the Gradle version here?
@@ -6,30 +6,12 @@ | |||
## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further to above, why are we changing Gradle here? This isn't in scope for the ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruebot Did not intend to change gradle version. Will review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 82.35% 70% -12.36%
Complexity 3 3
==========================================
Files 2 3 +1
Lines 51 60 +9
==========================================
Hits 42 42
- Misses 9 18 +9
Continue to review full report at Codecov.
|
Superseded by #36 |
GitHub Issue: (link)
What does this Pull Request do?
What's new?
How should this be tested?
One way to test this is to create a sample log or file route. An example is provided below. Can verify that the component is working via logs!
<< People with better camel expertise, please provide additional instructions >>
Additional Notes:
Danny noted that Pipeline or boradcast could be re-factored into one component with ExchangePattern option being passed in as a header to RoutlingSlip. Needs further research.
This is pretty much Danny's code, I had a chance to understand it.
Interested parties
@dannylamb
@Islandora-CLAW/committers