Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline #35

Closed
wants to merge 5 commits into from
Closed

Pipeline #35

wants to merge 5 commits into from

Conversation

Natkeeran
Copy link
Contributor

GitHub Issue: (link)

What does this Pull Request do?

  • This PR implements the RoutingSlip or Pipeline camel route.

What's new?

  • pipeline component

How should this be tested?

One way to test this is to create a sample log or file route. An example is provided below. Can verify that the component is working via logs!

    	from("timer:foo?period=5000")
    	.log(INFO, LOGGER, "Hello World")
    	.setHeader("IslandoraPipelineRecipients", simple("broker:queue:testqueue"))
    	.to("broker:queue:islandora-connector-pipeline");

<< People with better camel expertise, please provide additional instructions >>

Additional Notes:

Danny noted that Pipeline or boradcast could be re-factored into one component with ExchangePattern option being passed in as a header to RoutlingSlip. Needs further research.

This is pretty much Danny's code, I had a chance to understand it.

Interested parties

@dannylamb
@Islandora-CLAW/committers

Copy link
Member

@ruebot ruebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be dropping the Gradle version here, unless there is some rationale that I don't understand. Can you back out the Gradle version changes, and keep it at what it was before?

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.0-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-bin.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the reason for dropping the Gradle version here?

@@ -6,30 +6,12 @@
##
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further to above, why are we changing Gradle here? This isn't in scope for the ticket.

Copy link
Contributor Author

@Natkeeran Natkeeran Mar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruebot Did not intend to change gradle version. Will review.

Copy link
Contributor Author

@Natkeeran Natkeeran Mar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruebot
Created a new PR: #36. Please delete/reject this PR.

@codecov
Copy link

codecov bot commented Mar 14, 2017

Codecov Report

Merging #35 into master will decrease coverage by 12.35%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             master   #35       +/-   ##
==========================================
- Coverage     82.35%   70%   -12.36%     
  Complexity        3     3               
==========================================
  Files             2     3        +1     
  Lines            51    60        +9     
==========================================
  Hits             42    42               
- Misses            9    18        +9
Impacted Files Coverage Δ Complexity Δ
...dora/alpaca/connector/pipeline/PipelineRouter.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef0be0...18ff062. Read the comment docs.

@ruebot
Copy link
Member

ruebot commented Mar 14, 2017

Superseded by #36

@ruebot ruebot closed this Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants