Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary indexing #41

Merged
merged 7 commits into from
May 15, 2017
Merged

Binary indexing #41

merged 7 commits into from
May 15, 2017

Conversation

dannylamb
Copy link
Contributor

GitHub Issue: Islandora/documentation#624

What does this Pull Request do?

Adds routes to ingest LDPNRs in response to write events on Media entities in Drupal.

What's new?

Lots of new routes and config. Lots of tests. The update workflow for binaries is quite large.

How should this be tested?

Instructions on Islandora/documentation#624

Additional Notes:

Requires several other PRs to test, see Islandora/documentation#624

Interested parties

@ruebot @Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented May 15, 2017

Codecov Report

Merging #41 into master will increase coverage by 7.99%.
The diff coverage is 97.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
+ Coverage     84.16%   92.16%   +7.99%     
- Complexity       29       52      +23     
============================================
  Files             6        7       +1     
  Lines           240      651     +411     
  Branches          1        3       +2     
============================================
+ Hits            202      600     +398     
- Misses           37       48      +11     
- Partials          1        3       +2
Impacted Files Coverage Δ Complexity Δ
...slandora/alpaca/indexing/fcrepo/FcrepoIndexer.java 99.02% <100%> (+2.32%) 5 <2> (+2) ⬆️
.../ca/islandora/alpaca/indexing/fcrepo/AS2Event.java 87.5% <100%> (+2.88%) 9 <2> (+2) ⬆️
...slandora/alpaca/indexing/fcrepo/AS2Attachment.java 60% <60%> (ø) 4 <4> (?)
...dora/alpaca/indexing/fcrepo/FcrepoIndexerBean.java 90.83% <95.38%> (+10.83%) 28 <19> (+15) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca45c8...c09ea34. Read the comment docs.

@ruebot ruebot merged commit f3895b4 into Islandora:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants