Islandora connector houdini #49
Conversation
| }) | ||
|
|
||
| // Make a HEAD request for the Node | ||
| .removeHeaders("*", "Authorization") |
There was a problem hiding this comment.
Does this assume the node is publicly available, is there a JWT on the event we could reuse?
There was a problem hiding this comment.
Yeah totally. That's what this code is doing. The second (and any subsequent) parameter(s) to removeHeaders() are patterns that identify headers to keep. We're maintaining the Authorization header all the way down, which is populated here: https://github.com/Islandora-CLAW/islandora/blob/6e4815ef8743889b4bbd9d9870d2c60f21fe5fc3/src/EventGenerator/EmitEvent.php#L143
| } | ||
|
|
||
| private void regexSearchAndSetProperty(String regex, String[] links, String propertyName, Exchange exchange) { | ||
| Pattern pattern = Pattern.compile(regex); |
There was a problem hiding this comment.
Seeing as how you have 3 of these patterns that you use for each request. It might be better to compile them as class variables once and just use them in here.
|
This is now wrapped up in Islandora/documentation#86 |
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
============================================
+ Coverage 77.31% 79.47% +2.16%
- Complexity 16 56 +40
============================================
Files 4 11 +7
Lines 119 229 +110
Branches 1 1
============================================
+ Hits 92 182 +90
- Misses 26 46 +20
Partials 1 1
Continue to review full report at Codecov.
|
GitHub Issue: Islandora/documentation#766
What does this Pull Request do?
Provides a camel listener to send images to Houdini and place the results back in Drupal.
What's new?
How should this be tested?
Testing instructions to come.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers