Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lockfile to dev dependencies #27

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Aug 7, 2019

GitHub Issue: N/A

When we pinned to islandora/chullo: dev-dev we didn't update the lockfile and so were still installing older versions of Chullo which (I'm pretty confident) results in this error on this PR

What does this Pull Request do?

Updates the lockfile

How should this be tested?

Still passes travis and installs chullo version dev-dev when you clone it and do a composer install

Interested parties

@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@e65b2bb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev      #27   +/-   ##
======================================
  Coverage       ?   92.53%           
  Complexity     ?      136           
======================================
  Files          ?        9           
  Lines          ?      415           
  Branches       ?        0           
======================================
  Hits           ?      384           
  Misses         ?       31           
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65b2bb...871d558. Read the comment docs.

@dannylamb dannylamb merged commit 988ad57 into Islandora:dev Aug 7, 2019
@dannylamb
Copy link
Contributor

Nice catch @whikloj

@whikloj whikloj deleted the update-lockfile branch August 7, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants